Repository navigation
Fix unattended SignPath signature verification - #1780
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first SignPath request completed successfully, but Windows CI stalled while adding the pinned self-signed certificate to
CurrentUser\Root: that store can display an interactive consent dialog. Verify using the disposable hosted runner'sLocalMachine\Rootinstead, retain thumbprint checks andfinallycleanup, and bound verification to five minutes with progress messages. This is confined to the ephemeral runner and does not alter end-user trust.The account record now confirms the owner-installed GitHub App and links the completed SignPath request. The active plan still leaves Windows signature acceptance incomplete until the corrected hosted run passes.
Validation: actionlint and
git diff --checkpass;TMPDIR=/private/tmp pnpm test:contract:workflowpasses all 105 assertions in 12 files. The default macOS temp path reproduces the already-recorded #1774 fixture failures. This follow-up changes only the isolated signing verifier and its documentation; build inputs, application code and signing policy are unchanged. The preceding PR's clean build passed, and the current dev installer run remains pending without known failures. Real Windows validation follows thedevmerge.The Windows API behavior is documented in dotnet/runtime#24160.