[Implementation] Added a newMethod flag to support v6.45.1#88
Open
BernaLang wants to merge 3 commits intoTrakkasure:releasefrom
Open
[Implementation] Added a newMethod flag to support v6.45.1#88BernaLang wants to merge 3 commits intoTrakkasure:releasefrom
BernaLang wants to merge 3 commits intoTrakkasure:releasefrom
Conversation
fatdude
added a commit
to fatdude/mikronode
that referenced
this pull request
Aug 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the version 6.43 the api auth method was changed but it was only on version 6.45.1 released on 01/07/19 that it was made obligatory. This pull request adds a flag on the login function to be able to do login on the new version.
This implementation is not the best because i couldn't fully understand how the connection process works and my time was short.
But i tested on both versions and it seems to work fine.
I've also added info on the Readme and added a file to test the new auth method.