Fix text cutoff and skill cap stuck past level 75#2
Merged
Conversation
TreeFidyDad
changed the title
- Increase text_block_h from 52 to 62 in crystal/donut renderers - Extrapolate skill caps past level 75 instead of clamping - Prevent false capped state when table cap < actual skill value - Add Singing (40), String (41), Wind (42) for Bard at C rank Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
TreeFidyDad
force-pushed
the
treefidydad/fix-text-cutoff-bug
branch
from
June 24, 2026 14:53
76e34f3 to
f434a7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
1. Bottom row of text cut off in crystal/donut cards
The
text_block_hwas 52px — not enough vertical space for all 3 caption lines (skill name, cur/cap, level hint). Increased to 62px.2. Skill cap stops updating past level 75
When the engine's
GetCap()returns 0/nil, the fallbackskill_cap_for()was hard-clamped at level 75. This meant:Changes:
skill_cap_for()now extrapolates past level 75 using the end-slope ofCAP_REFtableseffective_level_for/min_mob_level_forsearch up to level 99cur > cap, bump cap tocur + 1so skills aren't falsely flagged as capped