add license note to address concerns in #2723 #2913
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@mfedderly @smallsaucepan I see you in the git history for README.md -- can I ask for a review? |
Collaborator
|
I’m considering just rewriting marchingsquares in Turf itself and then dropping the dependency entirely. It might be a few weeks though before I can get to it. |
Collaborator
|
@turf/isolines wasn't too bad, see #2918. Happy for feedback over there. |
Author
|
that's great @mfedderly ! Will keep my fingers crossed until merge, but I greatly appreciate the effort--this is a much better solution. |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2723 discusses licensing concerns related to the MarchingSquaresJS dependency, which is used in
turf-isobandsandturf-isolines. After review, it appears that the most common sources of concern related to this dependency's license are not relevant, becauseMarchingSquaresJSheavily modifies the AGPL with additional grants of permission. This PR adds a note to Turf's README file explaining this for others who will run across this same false positive when reviewing their licensing posture, hopefully saving them a little bit of time.