Draft
Conversation
mfedderly
commented
Feb 26, 2026
Collaborator
Author
mfedderly
left a comment
mfedderly
left a comment
There was a problem hiding this comment.
Note I did have to revert sweepline-intersections back to 1.5.0.
Hopefully this sets a baseline which lets us mass upgrade the world periodically and not have to fiddle with managing upgrades one at a time. pnpm also has a setting that lets us skip taking upgrades within N minutes, if we'd like.
| "no-redeclare": "off", | ||
| "no-var": "off", | ||
| "prefer-const": "off", | ||
| "no-useless-assignment": "off", // the remaning errors here require more thought to clean up |
Collaborator
Author
There was a problem hiding this comment.
The "fix" is to go from let x = 0 to just let x (or similar). There's <10 errors from this, but I'm afraid to make those changes without thinking about things more closely.
Collaborator
Author
|
Setting to draft for node support, perhaps we can get to this in v8 milestone instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran
pnpm upgrade -r --latestto yoink everything to the newest version around.This required several manual fixes included in the 2nd commit.