Rework No Heart Drops Code#1448
Open
SuperDude88 wants to merge 1 commit into
Open
Conversation
- Check the setting once in daItem_c::_daItem_create
Collaborator
Author
|
Known issue with this: hearts for castle town NPCs/end of Snowpeak ruins won't spawn. Not sure if this is fixable with this approach, will look into it. |
Collaborator
|
Is this mergable without fixing the known issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
daItem_c::_daItem_createinstead of in everyfopAcM_helper for creating an itemfopAcM_createItemFromTablebeing incorrectly treated as item IDsWorth doing more testing to validate the behavior changes/make sure no new issues are introduced.