Skip to content

Rework No Heart Drops Code#1448

Open
SuperDude88 wants to merge 1 commit into
mainfrom
no-hearts-rework
Open

Rework No Heart Drops Code#1448
SuperDude88 wants to merge 1 commit into
mainfrom
no-hearts-rework

Conversation

@SuperDude88
Copy link
Copy Markdown
Collaborator

  • Checks the setting once in daItem_c::_daItem_create instead of in every fopAcM_ helper for creating an item
  • No longer prevents hearts from being created as demo items (should never happen anyways? and would probably break)
  • Fixes table entries passed to fopAcM_createItemFromTable being incorrectly treated as item IDs
  • Prevents any freestanding hearts placed directly in the map with the dzr/dzs from spawning
  • Fixes Found another room that drops hearts when "Do Not Drop Hearts" is turned on. #1377/should cover more edge cases

Worth doing more testing to validate the behavior changes/make sure no new issues are introduced.

- Check the setting once in daItem_c::_daItem_create
@SuperDude88
Copy link
Copy Markdown
Collaborator Author

Known issue with this: hearts for castle town NPCs/end of Snowpeak ruins won't spawn. Not sure if this is fixable with this approach, will look into it.

@encounter
Copy link
Copy Markdown
Collaborator

Is this mergable without fixing the known issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Found another room that drops hearts when "Do Not Drop Hearts" is turned on.

2 participants