added core hmi modules and customization#136
Merged
Conversation
aaronrhim
force-pushed
the
feat/aaronrhim/new_hmi_skeleton
branch
from
54edb7b to
50b778b
Compare
Roozki
reviewed
Mar 28, 2026
| // ClassLoader<GuiModule> and receives concrete subclasses from any package that | ||
| // has registered them via a plugins.xml descriptor. | ||
| // | ||
| // To add a new module: |
Contributor
There was a problem hiding this comment.
Beutiful. this is proper cpp polymorphism
Roozki
reviewed
Mar 28, 2026
| QWidget* content() const { return content_; } | ||
| std::string title() const { return title_; } | ||
|
|
||
| signals: |
Contributor
There was a problem hiding this comment.
never seen this "signals" before. just a note
Contributor
Author
There was a problem hiding this comment.
Its only visible by qt's MOC (meta object compiler) in which it gets interpreted as a non-standard functionality
Contributor
Author
There was a problem hiding this comment.
It was part of a focus edit i made in that qt can differentiate how different keybinds work depending on where your mouse is hovering at that specific time
Roozki
approved these changes
Mar 28, 2026
Contributor
Roozki
left a comment
Roozki
left a comment
There was a problem hiding this comment.
Approving, but this may need to be reverted as the github actions are indeterminate rn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
woop!
Added a package just to handle the new GUI interface with some light customization and a catpuccin-like theme