Conversation
natlib/svcd.c
Outdated
There was a problem hiding this comment.
While it is a good abstraction for development, this may add extra overhead to the embedded system since SVCD need to be load/unload every time this function is called, but in reality, it only need to be load once.
Untitled
There was a problem hiding this comment.
I agree with Jack that this adds unnecessary overhead. The point of these C functions is that although they are ugly to write, you spend the time trying to optimise them. Development and prototyping would be done in Lua, in C you should be trying to be as efficient as possible
There was a problem hiding this comment.
This is experimental code that we forgot to remove.
There was a problem hiding this comment.
Can you please remove it before your final pull request due in 1 hour and 20 minutes?
|
I am not convinced that this code was tested, how does anon_function get visible in the global scope? Can you detail how this was tested? |
lib/svcd/svcd.lua
Outdated
There was a problem hiding this comment.
Not really sure what is going on with this bit of Lua left over. Do you still require it?
There was a problem hiding this comment.
Yea, we still require the invoke later. We were trying to switch it over to C and we got stuck.
natlib/svcd.c
Outdated
There was a problem hiding this comment.
You can remove this line; It was a special debugging statement. Was resolving a lua function SVCD.print_sendto...
4 participants
This is the same SCVD write pull request, except with a cleaned commit log. Please comment on either.
#36