Skip to content

Cds general stats on graph#87

Merged
Helias merged 134 commits intoUNICT-DMI:developmentfrom
ChiaraZuccaro:development
Feb 6, 2026
Merged

Cds general stats on graph#87
Helias merged 134 commits intoUNICT-DMI:developmentfrom
ChiaraZuccaro:development

Conversation

@ChiaraZuccaro
Copy link
Copy Markdown
Collaborator

Related to UNICT-Quality-Development/qd-projects#46

This PR includes a working graph for CDS general statistics only:

  • Added a Graph component;
  • Updated CdsService to return chart-ready formatted data after selection;
  • Refactored CdsService by separating responsibilities into dedicated formatting methods.

@Helias
Copy link
Copy Markdown
Member

Helias commented Feb 4, 2026

tests are failing in the pipeline.

btw, testing locally seems nice 🚀
image

@ChiaraZuccaro
Copy link
Copy Markdown
Collaborator Author

POST REVIEW
Based on the suggestions:

  • Created a utility to extract typed keys from a Record/object;
  • Combined workflows into a single pipeline for a happier life;
  • Defined a typed Record for SchedeOpis, used to format data for charts.

@@ -0,0 +1,3 @@
export function typedKeys<const T extends Record<PropertyKey, unknown>>(obj: T): (keyof T)[] {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this was necessary, but it's quite smart 👍

"prestart": "node scripts/set-env.js",
"start": "ng serve",
"build": "ng build",
"build": "node scripts/set-env.js && ng build",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some doubts about this set-env.js, I would prefer not have it at all, having some predefined settings that do not require any effort from the user/developer to setup the project

@Helias Helias merged commit 8afdb47 into UNICT-DMI:development Feb 6, 2026
4 checks passed
@Helias
Copy link
Copy Markdown
Member

Helias commented Feb 6, 2026

Well done 🚀, you are writing angular code in a modern way ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants