fixes after review

Author: eduard-dumitru

src/IpcSample.ConsoleClient/Client.cs

@@ -67,7 +67,7 @@ private static async Task RunTestsAsync(CancellationToken cancellationToken)
                     new ComplexNumber{ I = 0.2f, J = 0.1f },
                     new ComplexNumber{ I = 0.3f, J = 0.5f },
                 ], cancellationToken);
-                Console.WriteLine($"[TEST 2] sum of 2 complex number is:  {result3}", cancellationToken);
+                Console.WriteLine($"[TEST 2] sum of 2 complex number is: {result3}");
 
                 // test 4: call IPC service method without parameter or return
                 await systemClient.FireAndForgetWithCt(cancellationToken);

src/UiPath.CoreIpc.Extensions.Abstractions/UiPath.CoreIpc.Extensions.Abstractions.csproj

@@ -4,10 +4,9 @@
     <TargetFrameworks>net6.0;net461;net6.0-windows</TargetFrameworks>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
-    <LangVersion>preview</LangVersion>
+    <LangVersion>latest</LangVersion>
     <ImplicitUsings>true</ImplicitUsings>
     <Nullable>enable</Nullable>
-    <EnablePreviewFeatures>true</EnablePreviewFeatures>
     <AssemblyName>UiPath.Ipc.Extensions.Abstractions</AssemblyName>
     <RootNamespace>UiPath.Ipc.Extensions.Abstractions</RootNamespace>
   </PropertyGroup>

src/UiPath.CoreIpc.Extensions.BidirectionalHttp/UiPath.CoreIpc.Extensions.BidirectionalHttp.csproj

@@ -4,7 +4,7 @@
     <TargetFrameworks>net6.0;net461;net6.0-windows</TargetFrameworks>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
-    <LangVersion>preview</LangVersion>
+    <LangVersion>latest</LangVersion>
     <AssemblyName>UiPath.Ipc.Extensions.BidirectionalHttp</AssemblyName>
     <RootNamespace>UiPath.Ipc.Extensions.BidirectionalHttp</RootNamespace>
   </PropertyGroup>

src/UiPath.CoreIpc/Config/IpcClient.cs

@@ -23,21 +23,6 @@ private ServiceClient GetServiceClient(Type proxyType)
     }
     public TProxy GetProxy<TProxy>() where TProxy : class => GetServiceClient(typeof(TProxy)).GetProxy<TProxy>();
 
-    internal ILogger? GetLogger(string name)
-    {
-        if (Logger is not null)
-        {
-            return Logger;
-        }
-
-        if (ServiceProvider?.GetService<ILoggerFactory>() is not { } loggerFactory)
-        {
-            return null;
-        }
-
-        return loggerFactory.CreateLogger(name);
-    }
-
     internal RouterConfig CreateCallbackRouterConfig()
     => RouterConfig.From(
         Callbacks.OrDefault(),

src/UiPath.CoreIpc/Connection.cs

@@ -45,15 +45,15 @@ public Connection(Stream network, string debugName, ILogger? logger, int maxMess
 
     public override string ToString() => DebugName;
     public string NewRequestId() => Interlocked.Increment(ref _requestCounter).ToString();
-    internal Task Listen() => _receiveLoop.Value;
+    public Task Listen() => _receiveLoop.Value;
 
-    internal event Func<Request, ValueTask>? RequestReceived;
-    internal event Action<string>? CancellationReceived;
+    public event Func<Request, ValueTask>? RequestReceived;
+    public event Action<string>? CancellationReceived;
     public event EventHandler<EventArgs>? Closed;
 #if !NET461
     [AsyncMethodBuilder(typeof(PoolingAsyncValueTaskMethodBuilder<>))]
 #endif
-    internal async ValueTask<Response> RemoteCall(Request request, CancellationToken token)
+    public async ValueTask<Response> RemoteCall(Request request, CancellationToken token)
     {
         var requestCompletion = Rent();
         var requestId = request.Id;
@@ -98,7 +98,7 @@ internal async ValueTask<Response> RemoteCall(Request request, CancellationToken
             requestCompletion.Return();
         }
     }
-    internal ValueTask Send(Request request, CancellationToken token)
+    public ValueTask Send(Request request, CancellationToken token)
     {
         Logger?.LogInformation("Connection.Send...");
         var uploadStream = request.UploadStream;
@@ -107,7 +107,7 @@ internal ValueTask Send(Request request, CancellationToken token)
             SendMessage(MessageType.Request, requestBytes, token) :
             SendStream(MessageType.UploadRequest, requestBytes, uploadStream, token);
     }
-    void CancelRequest(string requestId)
+    private void CancelRequest(string requestId)
     {
         CancelServerCall(requestId).LogException(Logger, this);
         if (_requests.TryRemove(requestId, out var requestCompletion))
@@ -118,7 +118,7 @@ void CancelRequest(string requestId)
         Task CancelServerCall(string requestId) =>
             SendMessage(MessageType.CancellationRequest, SerializeToStream(new CancellationRequest(requestId)), default).AsTask();
     }
-    internal ValueTask Send(Response response, CancellationToken cancellationToken)
+    public ValueTask Send(Response response, CancellationToken cancellationToken)
     {
         var responseBytes = SerializeToStream(response);
         return response.DownloadStream == null ?
@@ -162,7 +162,8 @@ private async ValueTask SendStream(MessageType messageType, Stream data, Stream
     private async ValueTask SendMessage(MessageType messageType, MemoryStream data, CancellationToken cancellationToken)
     {
         Logger?.LogInformation("Connection.SendMessage: Awaiting the acquiring of the sendLock");
-        await _sendLock.WaitAsync(cancellationToken);
+        await _sendLock.WaitAsync(cancellationToken); /// ---------
+
         try
         {
             Logger?.LogInformation($"Connection.SendMessage: sendLock was successfully aquired. Pushing the bytes onto the network. ByteCount: {data.Length}");

src/UiPath.CoreIpc/Server/Server.cs

@@ -27,7 +27,7 @@ static Server()
     private readonly TimeSpan _requestTimeout;
 
     private ILogger? Logger => _connection.Logger;
-    private bool LogEnabled => Logger.Enabled();
+    private bool LogEnabled => _connection.LogEnabled;
     public string DebugName => _connection.DebugName;
 
     public Server(Router router, TimeSpan requestTimeout, Connection connection, IClient? client = null)

src/UiPath.CoreIpc/Wire/IpcJsonSerializer.cs

@@ -29,8 +29,8 @@ private void Serialize(object? obj, TextWriter streamWriter, JsonSerializer seri
         serializer.Serialize(writer, obj);
         writer.Flush();
     }
-    public char[] Rent(int minimumLength) => ArrayPool<char>.Shared.Rent(minimumLength);
-    public void Return(char[]? array)
+    char[] IArrayPool<char>.Rent(int minimumLength) => ArrayPool<char>.Shared.Rent(minimumLength);
+    void IArrayPool<char>.Return(char[]? array)
     {
         if (array is null)
         {