[ROBO-4985] RemoteException - Client StackTrace #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored `RemoteException` in `Dtos.cs` to handle stack traces differently for .NET Core and other frameworks. - Implemented the `DivideByZero` operation in `SystemService` to test exceptions. - Added `RemoteExceptionStackTrace_ShouldAlsoIncludeClientFrames` test to validate stack trace inclusion of client and server frames. - Added `ShouldPartiallyContainInOrder` method in `ShouldlyHelpers.cs` for enumerable validation with logging. - Removed unused namespaces and improved exception handling for clarity.
eduard-dumitru
force-pushed
the
feature/remoteex_clientstacktrace
branch
from
94ab9d6 to
af7467a
Compare
| return value; | ||
| } | ||
|
|
||
| public static void ShouldPartiallyContainInOrder(this IEnumerable<string> haystack, IEnumerable<string> needles, [CallerArgumentExpression(nameof(haystack))] string? supersetExpression = null, [CallerArgumentExpression(nameof(needles))] string? subsetExpression = null) |
Member
There was a problem hiding this comment.
I don't see the need of all this overhead just for logging. It can be far simpler
| StackTrace = error.StackTrace; | ||
| if (error.StackTrace is not null) | ||
| { | ||
| SetRemoteStackTrace(error.StackTrace); |
Member
There was a problem hiding this comment.
We should look into how the logs look with this change and if they help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoteExceptioninDtos.csto handle stack traces differently for .NET Core and other frameworks.DivideByZerooperation inSystemServiceto test exceptions.RemoteExceptionStackTrace_ShouldAlsoIncludeClientFramestest to validate stack trace inclusion of client and server frames.ShouldPartiallyContainInOrdermethod inShouldlyHelpers.csfor enumerable validation with logging.