-
Notifications
You must be signed in to change notification settings - Fork 4
Add Markdown Linting #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
codello
wants to merge
1
commit into
UltraStar-Deluxe:main
Choose a base branch
from
codello:linting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,29 @@ | ||
| # Contributing Guide | ||
|
|
||
| We're open for Pull Requests. | ||
| Our endgoal is to bond every community out there so we'd love to get in touch with you and partake in discussions on either [Issues](https://github.com/UltraStar-Deluxe/format/issues), [PR's](https://github.com/UltraStar-Deluxe/format/pulls) or [Discord - Format Related channel](https://discord.gg/tNEXZw2QJX) | ||
|
|
||
| ## Setup your IDE | ||
|
|
||
| If you want to contribute please setup your IDE or Editor correctly. | ||
| To do this you'll have to make sure the Editorconfig is used (works per default in VSCode) and that you have `pre-commit` installed so your commits are checked before pushing. | ||
|
|
||
| ### Install & configure pre-commit (through python) | ||
|
|
||
| Please execute the following commands within the repositories root directory. | ||
| This will install pre-commit to your system and installs the git hooks which check your changed code on commit if your changes adhere the conventions. | ||
|
|
||
| 1. `pip install pre-commit` | ||
| 2. `pre-commit install` | ||
|
|
||
| ### Linting | ||
|
|
||
| We want to ensure a consistent Markdown code style across this repository. | ||
| All markdown files will be linted via [`markdownlint-cli2-action`](https://github.com/DavidAnson/markdownlint-cli2-action). | ||
| You can run the linter locally by installing [`markdownlint-cli2`](https://github.com/DavidAnson/markdownlint-cli2) and then running | ||
|
|
||
| ```shell | ||
| markdownlint-cli2 "**/*.md" "#docs" "#.github/PULL_REQUEST_TEMPLATE.md" | ||
| ``` | ||
|
|
||
| We currently exclude the `docs` folder and the pull request template from the Markdown linting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| name: Linting | ||
| on: | ||
| push: | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| markdownlint: | ||
| name: Lint Markdown Files | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check out Code | ||
| uses: actions/checkout@v4 | ||
| - name: Run markdownlint-cli2 | ||
| uses: DavidAnson/markdownlint-cli2-action@v20 | ||
| with: | ||
| globs: | | ||
| **/*.md | ||
| !.github/PULL_REQUEST_TEMPLATE.md | ||
| !docs | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| default: true | ||
|
|
||
| # We have long lines due to semantic line breaks. | ||
| MD013: false # line-length | ||
|
|
||
| # GitHub understands subsequent blockquotes that are only separated by an empty line. | ||
| # This is required when using subsequent NOTE/TIP/WARNING blocks. | ||
| MD028: false # no-blanks-blockuote | ||
|
|
||
| # We want to use GitHub's summary/details blocks. | ||
| MD033: # no-inline-html | ||
| allowed_elements: [summary, details] | ||
|
|
||
| # The PULL_REQUEST_TEMPLATE.md does not meet this rule. | ||
| # We exclude linting on that file. | ||
| # MD041: false # first-line-h1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.