Fix inset colorbar frame reflow for refaspect#593
Draft
cvanelteren wants to merge 6 commits intomainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #592
With refaspect, the inset colorbar geometry is finalized during draw. Previously, we were reflowing the inset frame too late (effectively after draw scheduling), so some render paths used stale bounds and the frame no longer wrapped the label correctly.
The fix moves frame reflow into the actual draw path and runs it before artists are painted, using the active renderer. We also mark inset colorbars as needing reflow when created, so the frame is recomputed at the right time. That makes the frame/label layout deterministic across backends and preserves correct wrapping with refaspect.
A regression test was added to lock this behavior.