fix: skip recordDigestSent when RESEND_API_KEY absent (closes #2415)#2432
Open
Rudrasamadhiya wants to merge 1 commit into
Open
fix: skip recordDigestSent when RESEND_API_KEY absent (closes #2415)#2432Rudrasamadhiya wants to merge 1 commit into
Rudrasamadhiya wants to merge 1 commit into
Conversation
…a-io#2415) Updated the return type to include 'skipped' status and modified the logic to return a skipped status when no API key is provided.
GSSoC Label Checklist 🏷️@Umbrella-io — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
RESEND_API_KEYis absent,sendEmailpreviously returned{ ok: true }which causedrecordDigestSentto be called, advancinglast_digest_sent_ateven though no email was actually sent. On the next cron run, these users would be silently skipped until the next weekly window.This PR adds a
skippedflag to thesendEmailreturn type so the cron handler can detect when the email step was a no-op and skip the timestamp update accordingly.Changes
skipped?: booleantosendEmailreturn type{ ok: true, skipped: true }when API key is missingrecordDigestSentcall with!result.skippedCloses [BUG] Weekly digest cron treats missing RESEND_API_KEY as a successful send, consuming the 6-day cooldown with no email sent #2415