fix: prevent digest cooldown consumption when RESEND_API_KEY is missing#2433
Open
Sricharan106 wants to merge 1 commit into
Open
fix: prevent digest cooldown consumption when RESEND_API_KEY is missing#2433Sricharan106 wants to merge 1 commit into
Sricharan106 wants to merge 1 commit into
Conversation
|
Thanks for your first PR on DevTrack! 🎉 A maintainer will review it within 48 hours. While you wait:
If you find DevTrack useful, a ⭐ star on the repo is always appreciated — it helps the project grow and attract more contributors! |
GSSoC Label Checklist 🏷️@Umbrella-io — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
Author
|
@Priyanshu-byte-coder can you review the pr when you got time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the weekly digest cron reported emails as successfully sent when
RESEND_API_KEYwas not configured. Previously, users were marked as having received a digest and entered the 6-day cooldown period despite no email being delivered.Closes #2415
Type of Change
What Changed
sendEmail()to distinguish between successfully sent and skipped emails whenRESEND_API_KEYis not configured.last_digest_sent_atfrom being updated for skipped emails.How to Test
RESEND_API_KEYunset.last_digest_sent_atvalues are not updated and that skipped emails are reported separately.Expected result:
sentCountremains accurate.Additional Context
Before this change, deployments without a configured Resend API key could report successful email delivery while silently preventing users from receiving future digests due to the cooldown mechanism. This fix ensures cooldown timestamps are only recorded after a real email delivery attempt succeeds.