fix(theme): persist theme preference and respect system prefers-color-scheme#2440
Open
anuragbraveboy-sudo wants to merge 1 commit into
Open
fix(theme): persist theme preference and respect system prefers-color-scheme#2440anuragbraveboy-sudo wants to merge 1 commit into
anuragbraveboy-sudo wants to merge 1 commit into
Conversation
GSSoC Label Checklist 🏷️@Umbrella-io — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the issues surrounding theme preference persistence across the dashboard and public profile routes, and adds proper system default (
prefers-color-scheme) support on initial visits.Closes #2434
Key Changes
System Default Integration:
ThemeContext.tsxand the root injection script inlayout.tsxto inspect the client's OS color preference (prefers-color-scheme: dark) on their first visit if no manual theme override exists.localStoragewrite side-effect to avoid locking down the dynamic system preference on initial visit.localStorageread/write operations in safetry-catchblocks to protect against restricted environments.Unified Theme State:
ProfileThemeWrapper.tsxto consume the globalThemeContextdirectly. This eliminates the duplicate"profile-theme"storage key and aligns public profiles with the app's global theme selection.E2E Tests:
e2e/theme.spec.jswith page reload assertions to verify theme persistence on both the authenticated dashboard and public profiles.Verification
npx playwright test e2e/theme.spec.js(2/2 tests passed).