fix: support combined account filter in weekly summary endpoint (#2421)#2455
Open
shauryavardhan1307 wants to merge 10 commits into
Open
fix: support combined account filter in weekly summary endpoint (#2421)#2455shauryavardhan1307 wants to merge 10 commits into
shauryavardhan1307 wants to merge 10 commits into
Conversation
…ustomCursor style warnings
…onnection by returning mock data
GSSoC Label Checklist 🏷️@Umbrella-io — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
fe042e0 to
cf35165
Compare
Contributor
Author
|
Hi @Priyanshu-byte-coder,I have updated the PR to resolve the type-check and build failures:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves a
404 Account not founderror returned by/api/metrics/weekly-summary?accountId=combinedby implementing support for the"combined"account filter. The endpoint now aggregates commits, PRs, active days, streaks, and top repository statistics across all of the user's linked GitHub/external accounts.Closes #2421
Type of Change
What Changed
accountId === "combined".fetchWeeklySummaryForAccount.Promise.allSettled.7).How to Test
fix/weekly-summary-combined-2421.Expected result:
Screenshots / Recordings
No UI changes; this PR only updates backend route logic.
Checklist
console.log, debug code, or commented-out blocksAccessibility (UI changes only)
Not applicable (Backend-only change).
Additional Context
metrics:user-id:weekly-summary:{"accountId":"combined"}) to prevent collisions with individual account caches, while still utilizing cached data for each sub-account fetch.