Add keyboard and screen-reader support for dashboard widgets.#2458
Open
Honey-pg wants to merge 1 commit into
Open
Add keyboard and screen-reader support for dashboard widgets.#2458Honey-pg wants to merge 1 commit into
Honey-pg wants to merge 1 commit into
Conversation
Introduce a shared focusable widget shell with live region summaries for pilot metric widgets so users can tab to cards and hear title plus key stats.
GSSoC Label Checklist 🏷️@Umbrella-io — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce a shared focusable widget shell with live region summaries for pilot metric widgets so users can tab to cards and hear title plus key stats.
Adds keyboard and screen-reader support to dashboard widgets via a shared
DashboardWidgetShellandDashboardWidgetA11yContext. All widgets are now tab-reachable with visible focus rings and region labels; four pilot widgets (Streak, Goals, Language Breakdown, PR Metrics) announce dynamic metric summaries through polite live regions.Closes #2435
Type of Change
What Changed
src/components/dashboard/DashboardWidgetA11yContext.tsx— provider +useDashboardWidgetA11y()hook forsetSummary/setIsUpdatingsrc/components/dashboard/DashboardWidgetShell.tsx— focusablerole="region"wrapper with sr-only title, live summary region, focus ring, and Enter/Space to focus first inner controlSortableDashboardWidget.tsx— wraps widget content inDashboardWidgetShell(non-editing mode is tabbable; edit mode usestabIndex={-1})CustomizableDashboard.tsx— wraps the widget grid inDashboardWidgetA11yProviderStreakTracker.tsx— current/longest streakGoalTracker.tsx— active vs completed goalsLanguageBreakdown.tsx— top language + countPRMetrics.tsx— open PRs + merged (30d)test/components/DashboardWidgetShell.test.tsx,test/components/DashboardWidgetA11yContext.test.tsxHow to Test
/dashboardand press Tab repeatedly — each visible widget card should show a focus ring as it receives focus.Expected result: Widgets are keyboard-reachable with visible focus, titled regions for screen readers, and live announcements for the four pilot metrics. No mouse interaction regressions.
Automated checks:
npm run type-check npm run lint npm test -- test/components/DashboardWidgetShell.test.tsx test/components/DashboardWidgetA11yContext.test.tsx