test : added unit tests for og-user-params helpers#2464
Open
tmdeveloper007 wants to merge 1 commit into
Open
Conversation
GSSoC Label Checklist 🏷️@Umbrella-io — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2459.
Summary of What Has Been Done:
Added a dedicated vitest test file
test/og-user-params.test.tsthat pins the behaviour of every pure helper insrc/lib/og-user-params.ts. The tests are deterministic (no network, noDate.now) and use the samedescribe/it/expectstyle as the rest of the suite.Changes Made:
test/og-user-params.test.ts(14 tests, all passing undernpm test).normalizeOgUserParams(searchParams: URLSearchParams)export, including:usernamefalling back to"developer".namefalling back tousernamewhen missing.topLangfalling back to"JavaScript"when missing.nameandtopLangtruncating at theMAX_NAME_LENGTH(48) andMAX_LANGUAGE_LENGTH(24) caps.streakandcommitsreturning 0 for empty / non-numeric / negative inputs.streakandcommitsflooring decimal values.streakandcommitsclamping atMAX_METRIC_VALUE(999999) and accepting the boundary value 999999.Impact it Made:
Locks the contract for the public OG user-card query-param normaliser used by the
/api/og/userroute. Future refactors of the avatar URL composition, the fallback chain, or the metric clamping will surface a test failure rather than a silent UI regression. No production code was modified; the change is limited to one new test file.