-
Notifications
You must be signed in to change notification settings - Fork 3
Final Deployer Preparations #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@saucepoint must be a member of the protocols-tool-test team on Vercel to deploy. Learn more about collaboration on Vercel and other options here. |
marktoda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
separately we should make a script that enacts the proposal so we can generate calldata and seatbelt
941e315 to
212f4b5
Compare
snreynolds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good just comment suggestions, and I will re review after we merge #100
Final Deployer Prep: Add attestations and calldata generation to proposal script
This commit lowers the UNI burn thresholds to: - 4k UNI for mainnet - 2k UNI for unichain
0299fff to
89b4030
Compare
|
@wildmolasses please sign your commits so this can be merged! :) |
saucepoint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cant approve my own PR haha but agreed this ones getting quite big
| assertEq( | ||
| uniSupplyBefore - IERC20(RESOURCE).totalSupply(), THRESHOLD, "UNI not burned correctly" | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like the OP-bridged tokens decrement totalSupply for transfers to the bridge? super cool
DO NOT MERGE UNTIL: