Skip to content

Conversation

@dianakocsis
Copy link
Contributor

PR Scope

Please title your PR according to the following types and scopes following conventional commits:

  • fix(SDK name): will trigger a patch version
  • chore(<type>): will not trigger any release and should be used for internal repo changes
  • <type>(public): will trigger a patch version for non-code changes (e.g. README changes)
  • feat(SDK name): will trigger a minor version
  • feat(breaking): will trigger a major version for a breaking change

Description

[Summary of the change, motivation, and context]

How Has This Been Tested?

[e.g. Manually, E2E tests, unit tests, Storybook]

Are there any breaking changes?

[e.g. Type definitions, API definitions]

If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.

(Optional) Feedback Focus

[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]

(Optional) Follow Ups

[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]

@dianakocsis dianakocsis requested a review from a team as a code owner November 17, 2025 20:08
@graphite-app graphite-app bot requested a review from a team November 17, 2025 20:15
@graphite-app
Copy link

graphite-app bot commented Nov 17, 2025

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (11/17/25)

2 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation.

@jsy1218
Copy link
Member

jsy1218 commented Nov 18, 2025

let's add some more test

@jsy1218 jsy1218 merged commit 825d1b8 into main Nov 18, 2025
7 checks passed
@jsy1218 jsy1218 deleted the swap-permissions branch November 18, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants