-
Notifications
You must be signed in to change notification settings - Fork 298
Trajectory until node #1461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Trajectory until node #1461
Conversation
Depends on PR for the action definition. |
And add node to launch script Not quite done yet
So it can be reused elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, if we could improve the docs a little bit, this would be good to go!
I'll wait with merging this until ur_msgs 2.3.0 is merged into Rolling's rosdistro |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1461 +/- ##
==========================================
+ Coverage 3.59% 16.39% +12.80%
==========================================
Files 13 34 +21
Lines 947 3642 +2695
Branches 152 448 +296
==========================================
+ Hits 34 597 +563
- Misses 843 3027 +2184
+ Partials 70 18 -52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Two CI jobs were failing with
which is similar to the flaky tests we already have in the sjtc_illegal_trajectory_test. Let's try to resolve that one before and potentially also fix this before merging that in. |
Separate node for executing trajectories while also monitoring an until condition. Currently works with any motion controller, that uses the FollowJointTrajectory action, and the tool contact controller.