Skip to content

Conversation

URJala
Copy link
Collaborator

@URJala URJala commented Jul 18, 2025

Separate node for executing trajectories while also monitoring an until condition. Currently works with any motion controller, that uses the FollowJointTrajectory action, and the tool contact controller.

@URJala
Copy link
Collaborator Author

URJala commented Jul 18, 2025

Depends on PR for the action definition.

@URJala URJala requested a review from urfeex July 21, 2025 06:41
@URJala URJala force-pushed the trajectory_until branch from 5cf7bfb to 7350857 Compare July 30, 2025 09:18
Copy link
Member

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, if we could improve the docs a little bit, this would be good to go!

@urfeex
Copy link
Member

urfeex commented Jul 31, 2025

I'll wait with merging this until ur_msgs 2.3.0 is merged into Rolling's rosdistro

Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 12.38095% with 184 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.39%. Comparing base (1b121b7) to head (88bbcb4).
⚠️ Report is 491 commits behind head on main.

Files with missing lines Patch % Lines
ur_robot_driver/src/trajectory_until_node.cpp 12.38% 184 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main    #1461       +/-   ##
==========================================
+ Coverage   3.59%   16.39%   +12.80%     
==========================================
  Files         13       34       +21     
  Lines        947     3642     +2695     
  Branches     152      448      +296     
==========================================
+ Hits          34      597      +563     
- Misses       843     3027     +2184     
+ Partials      70       18       -52     
Flag Coverage Δ
unittests 16.39% <12.38%> (+12.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@urfeex
Copy link
Member

urfeex commented Oct 2, 2025

Two CI jobs were failing with

- ur_robot_driver.RobotDriverTest test_trajectory_until_can_cancel[my_ur_, passthrough_trajectory_controller]
  <<< failure message
    Traceback (most recent call last):
      File "/root/target_ws/src/Universal_Robots_ROS2_Driver/ur_robot_driver/test/integration_test_trajectory_until.py", line 142, in test_trajectory_until_can_cancel
        self.assertTrue(
    AssertionError: False is not true
  >>>

which is similar to the flaky tests we already have in the sjtc_illegal_trajectory_test. Let's try to resolve that one before and potentially also fix this before merging that in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants