fix: unleash.Initialize() method does not return error if client creation fails - #206
Merged
FredrikOseberg merged 1 commit intoSep 26, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Initialize function to properly return errors from NewClient.
Previously, Initialize would just return immediately, leaving it unclear whether the client was successfully initialized or if there was a connection/configuration issue.
With this change, callers of Initialize can now handle initialization errors gracefully.
Important files
unleash.go (updated Initialize function)
closes #205
Discussion points
Should we also consider adding a health check (pinging the Unleash server) during initialization, or is propagating the error enough for now?