chore: trim ci versions to reality - #247
Merged
Merged
Conversation
sighphyre
force-pushed
the
chore/fix-ci-to-break-on-invalid-go-versions
branch
from
March 11, 2026 11:44
0527716 to
35d3a91
Compare
sighphyre
marked this pull request as ready for review
March 11, 2026 11:44
gastonfournier
approved these changes
Mar 11, 2026
gastonfournier
left a comment
gastonfournier
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Would be awesome to have the CI fail if we suddenly have a stronger version requirement, but we can start be being honest in here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR #201 has pinned us to 1.23 and above. As of Go 1.21, the version specified in go.mod is no longer a hint, it's a requirement. The way our CI runs at the moment will allow for on the fly toolchain upgrades, so 1.21, 1.22 and 1.23 are all practically running on Go version 1.23