refactor: apply linter to fix issues - #134
Merged
Merged
Conversation
github-project-automation
Bot
moved this from In Progress
to Approved PRs
in Issues and PRs
Member
+1 to both these ideas. Probably better as a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed some linting issues and when run
swiftformat --lint .there were tons of them reported.So, applied
swiftformat .on the source base to fix those.After running it,
swiftformat --lint .reports clean 🟢To note: without a config, it uses SwiftFormat's defaults, so
swiftformat .will reformat to those defaults — which is exactly what--lintwas flagging, so the two agree, but with no extra rules that would make the code look 'prettier'.We could add rules (on CI) and a .swiftformat file at the repo root with our chosen options — then both swiftformat and swiftformat --lint read it. Same way as we do already on the provider