fix: resolve ios 12 compatibility with header lookup - #143
Merged
sighphyre merged 1 commit intoAug 17, 2026
Conversation
sighphyre
changed the base branch from
main
to
chore/add-minimum-version-check
August 17, 2026 08:28
sighphyre
marked this pull request as ready for review
August 17, 2026 08:39
sighphyre
force-pushed
the
fix/resolve-ios-12-compatibility-with-header-lookup
branch
from
August 17, 2026 08:52
1c4440a to
2817eee
Compare
sighphyre
changed the base branch from
chore/add-minimum-version-check
to
main
August 17, 2026 09:03
ppicom
self-requested a review
August 17, 2026 09:26
ppicom
approved these changes
Aug 17, 2026
sighphyre
deleted the
fix/resolve-ios-12-compatibility-with-header-lookup
branch
August 17, 2026 09:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes iOS 12 compatibility after the ETag header lookup change in 2.5.1, fixes #140. Alternative to #141 - this preserves the case insensitive matching for iOS 12 as well - missed etags are a significant enough problem for Unleash that I think it's worth making it sure it works for arbitrary iOS versions even if the code is uglier.