Skip to content

Conversation

@sighphyre
Copy link
Member

Restructures the connector APIs to be a bit cleaner and so that we can add in async variants of these. Effectively this only moves the load_features logic from the abstract base class into a pure function so that it can be reused by async connectors, since those will need their own ABC

@sighphyre sighphyre self-assigned this Nov 4, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19061071890

Details

  • 47 of 56 (83.93%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 93.352%

Changes Missing Coverage Covered Lines Changed/Added Lines %
UnleashClient/connectors/base_sync_connector.py 13 15 86.67%
UnleashClient/connectors/streaming_connector.py 3 5 60.0%
UnleashClient/connectors/hydration.py 15 20 75.0%
Totals Coverage Status
Change from base Build 19028210296: -0.3%
Covered Lines: 674
Relevant Lines: 722

💛 - Coveralls

@FredrikOseberg FredrikOseberg moved this from New to In Progress in Issues and PRs Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants