Conversation
When it's a status output. Yay.
Collaborator
Author
|
To cap it all, it's involved to test for. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting the correct exit code handling right. The core problem is that the Github Actions expression language is partially typed, a situation that is extremely annoying to work with. In particular, boolean tests work with booleans (and treat non-empty strings as always truthy), but outputs from actuibs and workflows are strings, even when generated by expressions (when non-string things will get invisibly stringified). That's horrible; literally the worst of all worlds; outputs like
0andfalseare true, however you interpret them (unless you run them through a string comparison test or interpret as JSON, which would be too Yikes! for me).