Skip to content

Conversation

@raller09
Copy link

dont change ShortCut Variable if found. Log the Path to console.

@UweRaabe
Copy link
Owner

Please use the existing coding style when proposing changes and never re-format any code.

  for I := 0 to Variables.Count - 1 do begin
    WriteRegistry(Variables.Names[I], Variables.ValueFromIndex[I]);
  end;

is changed to:


  for I := 0 to Variables.Count - 1 do
  begin
    WriteRegistry( Variables.Names[ I],
                   Variables.ValueFromIndex[ I],
                   True);
  end;

Note the blank line, the begin and the line break between parameters, which are totally unrelated to the intended code change.
This is how it should look instead:

  for I := 0 to Variables.Count - 1 do begin
    WriteRegistry(Variables.Names[I], Variables.ValueFromIndex[I], True);
  end;

The current changes lead to an inconsistent style and the real code changes are obfuscated by the style change.

While I accept projects having a different style than I prefer, I still take the right to enforce my style on my projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants