Skip to content

code review related modifications to use with mypy validation#3

Open
vsitnik wants to merge 1 commit into
VEuPathDB:masterfrom
vsitnik:master
Open

code review related modifications to use with mypy validation#3
vsitnik wants to merge 1 commit into
VEuPathDB:masterfrom
vsitnik:master

Conversation

@vsitnik
Copy link
Copy Markdown

@vsitnik vsitnik commented Nov 19, 2020

Could be an overkill. Perhaps there's no need in using @dataclass and stuff.
To run mypy validation do the following:

[ -f venv/bin/activate ] && source venv/bin/activate || python3 -m venv venv

which mypy || pip install mypy

mypy --pretty apollo_email_report/module/transcript.py
# Success: no issues found in 1 source file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant