[VEN-2940]: Add simulations for LBTC support #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Sometimes markets don't have huge amounts of cash available, e.g. on sepolia there's a shortage of WETH. This makes generic checks fail. However, it's a normal situation, especially on testnets – WETH wraps Sepolia ETH, so people supply free faucet tokens and borrow a token that has a higher demand. Solution: Ensure that the borrowed amount is less than available cash
web3rover
approved these changes
Nov 29, 2024
chechu
reviewed
Nov 29, 2024
chechu
approved these changes
Dec 4, 2024
Contributor
Problem: setDirectPrice does not directly set the returned value of the getPrice function. Rather, it is implied that the price is scaled by 1e18. Thus, when we call getPrice, extra zeros get appended to the price for tokens with < 18 decimals. Solution: Do a reverse scaling, i.e. divide by 10**(18 - decimals)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds simulations for enabling LBTC market on Ethereum Core pool