-
Notifications
You must be signed in to change notification settings - Fork 3
[VEN-2882]: VIP to transfer the ownership of the contracts to Governance #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Jesus Lanchas <[email protected]>
Co-authored-by: Jesus Lanchas <[email protected]>
|
Do we have intentionally set Default minimum delay to 1 hour in Normal timelock on basemainnet? |
| it("Normal Timelock should be the owner of the Vtreasury", async () => { | ||
| expect(await treasury.owner()).equals(basemainnet.NORMAL_TIMELOCK); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also test for pool registry's ownership
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@GitGuru7 No. It was the minimum delay by default in the contract https://github.com/VenusProtocol/governance-contracts/blob/develop/contracts/Governance/TimelockV8.sol#L17 Should we change it? |
@chechu WDYT? We've set a 2-day delay on other chains. What should we maintain as the minimum delay for NT on Base. |
I would keep it as it is (1 hour), because 1) VIP-408 is already granting this Normal Timelock permissions, and 2) because any change on the delay will be via VIP, so it can be reviewed before execution |
chechu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commands lgtm
|
Base Sepolia Multisig Txn: https://sepolia.basescan.org/tx/0x9bb21ee68e1e900a847c63a15c2d70a9e46abc0bcf2e95f9eef659c320dfaa41 |
|
Base Sepolia remote commands: https://sepolia.basescan.org/tx/0x7d234e695b1b359b4c3248116115ce82db9addc320297df6b732ac0cc11cc3c5 |
chechu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainnet commands lgtm
chechu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The transfer of ownership of the NTG lgtm
Description
Resolves VEN-2882