Theory of rational relations (custom transducers) - #405
Merged
Conversation
jurajsic
changed the title
jurajsic
marked this pull request as ready for review
July 22, 2026 11:23
vhavlena
reviewed
Jul 24, 2026
vhavlena
left a comment
vhavlena
left a comment
Collaborator
There was a problem hiding this comment.
Great work! Just a couple of minor comments.
Collaborator
|
Also, can you add e2e tests containing |
Co-authored-by: Juraj Síč <juraj.sic@outlook.com>
…to rational_relations
Member
Author
I added the tests.I would not add the projection operator for now, it would be a new regex operator and I am not sure what everything I need to change for it to work properly. We will anyway support only explicit rational relations, and I think for that projection is not that needed. |
vhavlena
approved these changes
Jul 25, 2026
jurajsic
commented
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.