EET on VITM 2 activitysim #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 3, 2022 21:10
…rch where they are non-increasing - re-adjust util calc. should really document this somewhere
…raction_sample_simulate
# Conflicts: # activitysim/core/configuration/top.py # activitysim/core/interaction_sample.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion pull request to ActivitySim#1029, constructed in a slightly different manner, to target v1.5.1 instead of main. I've
As a result of this you can see the diff as just EET changes on top, and consequently, things look quite similar between https://github.com/janzill/activitysim/pull/3/changes
and this (https://github.com/VictoriaTransport/activitysim/pull/6/changes)
The largest difference is in interaction_sample.py where I've made EET compatible with the changes introduced in ActivitySim#917 (worth noting we haven't run the estimation mode though)