Drawer

[cindyunrau]

Added Current and Previous Courses to the drawer:
To-do:

• fix issue where all nested lists open whenever one is clicked
• GPA is currently hard-coded
• courses need to be taken and sorted into the appropriate semesters based on date range

[BraidenCutforth]

Looks really good! Just need to make some changes in drawer content mainly and I think it will be ready to go!

[BraidenCutforth]

Test component?

[cindyunrau]

I was going to use this to take the input date range from courses and sort them into their appropriate semesters. Didn't start implementation yet.

[BraidenCutforth]

Looks good! We should look into trying to use the material-ui styles though as suggested. Once we make that change we are good to merge!

[BraidenCutforth]

We should use the material-ui styling ways instead of CSS properties. We can convert this pretty easily. In the useStyles const, add a key like

drawerContent: {
    backgroundColor: '#F5F5F5', // There might be something like theme.pallette.something, if you can find it, great, if not just use this constant for now
    paddingTop: theme.spacing(1), // 1 or more, adjust based on what you want
    paddingBottom: theme.spacing(1), // same as above
    height: '100%',
}

Once that is done, then you can use the className property instead of the styles property, suggested below.

[BraidenCutforth]

Similar as above.

[BraidenCutforth]

Once you change the way the styling is written above, this is the change you need down here

Suggested change

	<div id="drawer_content" style={drawerContent}>
	<div id="drawer_content" className={classes.drawerContent}>

[daelynj]

@BraidenCutforth It looks like your editor applied some formatting to package.json and package-lock.json by accident. This is avoidable if you only add the files to your commits that you've worked on rather than doing a git add . to commit every change.

This has small effects such as changing 7587 lines of code in the repository. Also changing the history of the two files, and when this code gets merged, will change everyone's versions of these files as well. But it's solvable with an interactive rebase if you feel like it!

[BraidenCutforth]

This was a commit I made to fix some line endings. My editor is set to format json like this on purpose. It probably shouldn't happen here though you're right and we should uncommit this change.

[daelynj]

@BraidenCutforth My bad, your GitHub profile pictures look pretty much the same, I didn't see you had commits lol

[daelynj]

I would suggest placing any global changes to CSS like this in a separate PR; while it's a font you want to use, it's not specifically related to the component you are building. It's always best to write small PRs and separate things that are unrelated to each other.

[BraidenCutforth]

I think this was also me, and again should be separate PR. I think this might actually not be needed though.

[daelynj]

Looks like another format thing your editor did by accident 🙃

[daelynj]

It would be great to have the message body of this PR say what you've created and why you've created it, with a link to a ticket or something of the sort. That would save people a few minutes having to figure it out in the future! A descriptive PR title would help as well, such as "Implement Drawer component" rather than just "Drawer".