chore(ci): run checks for workflow and interpreter-version changes - #97
Merged
Merged
Conversation
The python path filter covered only src/, tests/, pyproject.toml and uv.lock, so a PR touching just the workflows, .python-version or the Dockerfile skipped Lint, Unit Tests and Skills Sync and reported every check green having run none of them. That is how the action bumps have been landing. #92 (setup-uv v9), #88 (checkout v7), #89 (cache v6) and #53 (python 3.14) all show "skipping" rather than pass — they modify CI itself, or the interpreter it runs on, and were never exercised before merge. Adds the three paths. This PR touches .github/workflows/** and so is its own first test case: the jobs should run here rather than skip. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
pythonpath filter (ci.yaml:25-30) covered onlysrc/**,tests/**,pyproject.tomlanduv.lock. Lint, Unit Tests and Skills Sync are all gated on it.So a PR that changes only the workflows,
.python-version, or theDockerfileskips every job — and GitHub reports the PR as green, having run nothing.This is not hypothetical. Of the Renovate PRs currently open, four show
skippingrather thanpass:Three of those modify CI itself and one changes the interpreter — the changes most likely to break the build are the ones the build never sees. You find out after merging to
main.Change
Adds
.github/workflows/**,.python-versionandDockerfileto thepythonfilter.Verification
ci.yamlparses; filter resolves to['src/**', 'tests/**', 'pyproject.toml', 'uv.lock', '.github/workflows/**', '.python-version', 'Dockerfile'].github/workflows/**and nothing else, so onmaintoday it would skip everything. If the checks below actually ran, the fix works.Note
This makes the four PRs above run real checks once rebased, which may surface genuine failures that were previously invisible. That is the point, but it means they should be merged one at a time rather than batched.
🤖 Generated with Claude Code