Fix Recursive Case Class Decoding #393
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! @lbialy should be able to review, but might be later this month. |
tgodzik
reviewed
May 21, 2025
| @@ -577,3 +577,39 @@ class DecoderSuite extends munit.FunSuite: | |||
| case Right(value) => | |||
| fail(s"Should fail, but got $value") | |||
| } | |||
|
|
|||
| test("Recursive case class".only) { | |||
There was a problem hiding this comment.
Suggested change
| test("Recursive case class".only) { | |
| test("Recursive case class") { |
this fails on CI
| $m: Mirror.SumOf[T] { type MirroredElemTypes = `elementTypes` } | ||
| } => | ||
| val instancesExpr = Expr.ofList(summonSumOf[elementTypes]) | ||
| '{ | ||
| new YamlDecoder[T] { | ||
| private val instances = $instancesExpr.asInstanceOf[List[YamlDecoder[T]]] | ||
| private val instances = $instancesExpr.asInstanceOf[List[YamlDecoder[Any]]] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue with decoding recursive case classes in the library. The patch addresses a bug where recursive case classes failed to be parsed correctly from YAML. A test case for a Tree trait with Branch and Leaf case classes was added to demonstrate the fix.
Although I'm not an expert in Scala or metaprogramming, I worked through the problem and implemented a solution based on my understanding.