Skip to content

Conversation

behei-vonage
Copy link
Contributor

@behei-vonage behei-vonage commented Sep 5, 2025

What is this PR doing?

This PR fixes an issue where On the participants list, on muting the publisher the muted icon is not displayed

How should this be manually tested?

Steps to reproduce:

  • Checkout develop branch.
  • Join a meeting room, and mute the publisher.
  • Notice on the publisher tile, we can see that the pub is muted. (blue colored loudness indicator is switched to muted icon).
  • Notice on the Participants list we still see the loudness indicator and not the muted icon.

Expected: On the Participants list we should see the muted icon.

To check the fix:

  • Checkout this branch.
  • Follow the steps above, notice the issue above is no longer happening, i.e. audio indicators match.

What are the relevant tickets?

A maintainer will add this ticket number.

Resolves VIDSOL-28

Checklist

[ ] Branch is based on develop (not main).
[👍 ] Resolves a Known Issue.
[👍 ] If yes, did you remove the item from the docs/KNOWN_ISSUES.md?
[ ] Resolves an item reported in Issues.
If yes, which issue? Issue Number?

@behei-vonage behei-vonage self-assigned this Sep 5, 2025
Copy link
Contributor

@cpettet cpettet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Just have a few comments/questions. Let me know what you think!

@behei-vonage behei-vonage requested a review from cpettet September 8, 2025 19:40
Copy link

sonarqubecloud bot commented Sep 8, 2025

Copy link
Collaborator

@v-kpheng v-kpheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪 🚀

(That said, I see some nits but I'll shut up 🙊)

Copy link
Contributor

@cpettet cpettet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Great job! :shipit:

@dwivedisachin
Copy link
Collaborator

Tested LGTM!!

@dwivedisachin dwivedisachin merged commit fbde556 into develop Sep 10, 2025
8 checks passed
@dwivedisachin dwivedisachin deleted the behei-vonage/vidsol-28-muted-icon branch September 10, 2025 18:05
behei-vonage added a commit that referenced this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants