Skip to content

Conversation

behei-vonage
Copy link
Contributor

What is this PR doing?

This PR fixes an issue where Record meeting shows incorrect option for the user who has not started the recording

How should this be manually tested?

Steps to reproduce:

  • Checkout the develop branch.
  • Join a meeting from 2 tabs
  • On tab 1 start recording
  • On tab 2 notice the red recording indicator.
  • On tab 2 Click on the Stop recording button
  • Notice we get a Start recording card, instead of the stop recording one

To check the fix:

  • Checkout this branch.
  • Follow steps above, notice that correct messages are being displayed.

What are the relevant tickets?

A maintainer will add this ticket number.

Resolves VIDSOL-25

Checklist

[ ] Branch is based on develop (not main).
[ ] Resolves a Known Issue.
[ ] If yes, did you remove the item from the docs/KNOWN_ISSUES.md?
[ ] Resolves an item reported in Issues.
If yes, which issue? Issue Number?

@behei-vonage behei-vonage self-assigned this Sep 5, 2025
Copy link

sonarqubecloud bot commented Sep 5, 2025

Copy link
Contributor

@cpettet cpettet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Great job! :shipit:

Copy link
Collaborator

@v-kpheng v-kpheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪 🚀

@dwivedisachin
Copy link
Collaborator

Tested LGTM!! 🚀

@dwivedisachin dwivedisachin merged commit dcb32ef into develop Sep 10, 2025
9 checks passed
@dwivedisachin dwivedisachin deleted the behei-vonage/vidsol-25-archiving branch September 10, 2025 18:18
behei-vonage added a commit that referenced this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants