Set up testing and write tests for blocks reducer #14

Vui-Chee · 2021-06-16T06:40:57Z

Summary

Set up Jest for testing
write test cases for these actions (NEW_PIECE, ROTATE, JUST_MOVE, INSTANT_LAND, CLEAR_ROWS)

Directory structure (tentative)

The tests as of now is currently divided according to situations.

__tests__
  blocksReducer
    createPiece.js
    utils.js (functions created to assist testing)
    testUtils.js (tests for external functions)
    rotation.js
    movement
      singleDirection.js
      twoDirections.js
      noMoveIntoWalls.js
      combine.js
    instantMove
        combineWithFloor.js
        combineWithLandedBlocks.js
    clearRows.js

Test create new valid piece.

Only in 'L' orientation.

* use toBe (no need for deep comparison) * one more case testing if stick piece is just far enough from wall to rotate

Otherwise, there could unusual state overwrites interfering with later tests.

In upside down position. + minor updates.

So previous orientation test after each rotation is removed.

Note this only tests one orientation.

Only in one orientation.

* Split rotation cases into separate file * Export reusable functions in utils.js

By splitting cases.

So should extract every key value from initial state and overwrite desired fields.

function should only be focused on testing movement action.

+ reorg some cases.

Use to generate test extravagant cases.

Vui-Chee added 30 commits June 14, 2021 19:12

Basic jest setup

b5259fd

Test isOutOfBounds function

5011eec

Use jest option to run tests faster

ce377fd

Test isMoveValid with simple piece for now

c7ec148

Update jest config

cb157f4

Git ignore generated coverage folder

c305a3b

Initial reducer test

06b6b03

Test create new valid piece.

Test each piece rotation

354f59c

Test case L2 piece cannot rotate next to left wall

effe402

Only in 'L' orientation.

Test case S piece cannot rotate close to left wall

e13d969

Update prev test case

00d9641

* use toBe (no need for deep comparison) * one more case testing if stick piece is just far enough from wall to rotate

Use toBe instead of toEqual for comparing nums

fbde6d0

Do not hardcode number of cols/rows during testing

0d745d9

Test case S piece cannot rotate next to right wall

9e95a0e

Create a new copy of each state slice per test

eb157ab

Otherwise, there could unusual state overwrites interfering with later tests.

Test L2 piece cannot rotate touching right wall

b46e856

Test L1 piece cannot rotate touching left wall

905eccd

In upside down position. + minor updates.

Test L1 piece cannot rotate touching right wall

e6c5ccd

Drop example test

72b4e23

Test T piece cannot rotate flat side against wall

2a0ecaf

Test Z piece 1 cannot rotate against left wall

098264e

Test Z piece 2 cannot rotate against right wall

b06307c

Test S piece retains shape after each rotation

ef1626d

Test T piece retains shape during rotations

7ea513b

Test L_PIECE_1 retains shape during rotations

85da382

Test L_PIECE_2 retains shape during rotations

ff4fc99

Test Z_PIECE_1 returns shape during rotations

c92ae04

Test Z_PIECE_2 returns shape during rotations

a3d43b1

Test both orientation and shape retention together

b20af8a

So previous orientation test after each rotation is removed.

Initial test movement without blocks combination

9a66633

Vui-Chee added 13 commits June 18, 2021 11:36

Relocate testMove func + params directions

bf24b6d

Test L_PIECE_1 movement in 2 directions

fdd8b2b

Helper functions to configure current piece

d633068

Initial test L_PIECE_1 combine with floor

4b061ff

Test combine L_PIECE_1 with landed L_PIECE_1

2f18b03

Test combine L_PIECE_1 on moving in 2 directions

2ae9ab0

Add right & down movement test case (L_PIECE_1)

afe1f1a

Test L_PIECE_1 cannot move into left/right walls

6378127

Test movement for remaining blocks

294f91d

Note this only tests one orientation.

Remaining cases for movement in 2 directions

a6c9a0e

Only in one orientation.

Initial splitting of tests

5b46daa

* Split rotation cases into separate file * Export reusable functions in utils.js

Update package-lock.json

053067b

Further split tests according to situations

88e3b0d

Vui-Chee changed the title ~~Blocks reducer tests~~ Set up testing and write tests for blocks reducer Jun 20, 2021

Vui-Chee added 6 commits June 20, 2021 11:52

Update test for NEW_PIECE action

24b7ba1

By splitting cases.

Create state based on reducer initial state

79017c5

So should extract every key value from initial state and overwrite desired fields.

Extract rotation logic from testMove

4e3160b

function should only be focused on testing movement action.

Clearer test descriptions for testUtils

d793fea

+ reorg some cases.

Ignore tools folder

5338e86

Use to generate test extravagant cases.

Test movement for L_PIECE_1 in all orientations

01bcdd2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Set up testing and write tests for blocks reducer #14

Set up testing and write tests for blocks reducer #14

Uh oh!

Vui-Chee commented Jun 16, 2021 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Set up testing and write tests for blocks reducer #14

Are you sure you want to change the base?

Set up testing and write tests for blocks reducer #14

Uh oh!

Conversation

Vui-Chee commented Jun 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Directory structure (tentative)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Vui-Chee commented Jun 16, 2021 •

edited

Loading