fix: Auto media detection, Starlette compat, and burn error reporting#3
Draft
demrich wants to merge 1 commit into
Draft
fix: Auto media detection, Starlette compat, and burn error reporting#3demrich wants to merge 1 commit into
demrich wants to merge 1 commit into
Conversation
- Probe drive with udevadm when media_type=AUTO to select correct burner backend (wodim for CDs, growisofs for DVDs) instead of always defaulting to growisofs which fails on CD-R media - Add Starlette 1.0.0 TemplateResponse compatibility shim to fix unhashable dict crash on web UI load - Fix burn_completed event in web UI to check result status and display actual error instead of always reporting success - Change dryRun default to false so burns execute by default Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
media_type=auto, the burner backend now probes the drive viaudevadmto detect inserted media (CD vs DVD vs BD) and selects the correct backend (wodimfor CDs,growisofsfor DVDs). Previously it always defaulted togrowisofs, which fails on CD-R media with exit code 252.TemplateResponseAPI change (positional args reordered), fixing anunhashable type: 'dict'crash on every page load.dryRundefault fromtruetofalsein the burn workflow UI so burns execute by default.Test plan
media_type=autoand confirmwodimis selected (check logs for "AUTO media detection")media_type=autoand confirmgrowisofsis selected