Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates multiple NES-LTER API “download” endpoints to use .csv-suffixed URLs (and adds/adjusts a few related data-handling rules), then updates the automated test suite and landing-page links to match.
Changes:
- Updated many API routes and UI links to use
.csvfor file downloads (CTD, Underway, Events, Nut, Chl, HPLC, Stations). - Added/adjusted special-case data handling: extra bottle metadata handling for select cruises, skip nutrient flag generation for AR78, and add AE2426 underway column definitions.
- Updated automated tests to validate the new
.csvendpoints and some new/adjusted outputs.
Reviewed changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/vessels.js | Adds coverage for new vessels CSV download endpoint. |
| tests/underway.js | Switches underway data + column definition file checks to .csv and updates AE2426 column-definition expectations. |
| tests/station.js | Updates stations file download to /file.csv. |
| tests/nut.js | Switches nutrient endpoints to .csv, updates expected counts, adds AR52 samplelog CSV test. |
| tests/niskin.js | Adds niskins CSV download test and updates JSON field expectation (niskin_number). |
| tests/metadata.js | Switches CTD metadata to .csv and adds bathymetry CSV test. |
| tests/landing.js | Updates landing-page link targets to .csv for file downloads and adjusts window-handle switching. |
| tests/hplc.js | Updates HPLC fetch to .csv. |
| tests/event.js | Updates events fetch to .csv. |
| tests/cruise.js | Adds cruises CSV test and keeps JSON “all cruises” test. |
| tests/chl.js | Updates chlorophyll endpoints to .csv. |
| tests/cast.js | Adds casts CSV “all” test and updates single-cast download to .csv. |
| tests/bottle.js | Updates bottles + bottle_summary downloads to .csv. |
| api/underway/services.py | Adds AE2426 underway column definitions and introduces JSON column-definition support alongside CSV. |
| api/underway/api.py | Adds /column_definition/{cruise}.csv and changes underway data route to /{cruise}.csv. |
| api/stations/api.py | Renames stations file route to /file.csv. |
| api/nut/services.py | Changes AR52 nutrient samplelog merging approach. |
| api/nut/management/commands/importnut.py | Skips nutrient flag generation for ar78. |
| api/nut/api.py | Renames nutrient routes to .csv. |
| api/hplc/api.py | Renames HPLC route to .csv. |
| api/events/api.py | Renames events route to .csv. |
| api/ctd/services.py | Adds JSON responses for vessels/cruises “all”, adds CSV endpoints for vessels/cruises/casts/niskins, renames NiskinOutput field. |
| api/ctd/management/commands/importniskin.py | Adds special-case handling for cruises missing bottle metadata (AR28B/AR24A/AR39A). |
| api/ctd/api.py | Adds/renames CTD routes for CSV downloads (vessels/cruises/casts/cast/niskins/bottles/metadata/bathymetry). |
| api/core/utils.py | Adjusts missing-.btl handling logic in read_nut_data. |
| api/core/templates/cruise_list.html | Updates landing page links to .csv download URLs. |
| api/chl/api.py | Renames chlorophyll routes to .csv. |
| .github/workflows/publish-image-api.yml | Changes workflow branch trigger list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
Made copilot suggested changes and pushed up to csv branch. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes include: