initial refactor to remove mediastore client in favor of BucketStore (untested) - #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how storage configuration is handled across the codebase by centralizing all S3 and store-related environment variable management into the
get_store()utility function. This removes the need to pass storage credentials and configuration throughout the code, simplifying service and command implementations and improving maintainability. The code now supports S3-based storage viaamplify-storage-utilsBucketStoreclass, and eliminates the previous dependency onMediaStore.Storage Refactoring and Centralization:
All usages of
get_store()across management commands, services, and views have been refactored to no longer require passingURL,TOKEN, orMEDIASTORE_PREFIXparameters. These are now read from environment variables directly withinget_store(). [1] [2] [3] [4] [5] [6] [7] [8]All
get_store()calls in commands, services, and views have been updated to use the new signature, further simplifying the code and reducing duplication of environment variable handling. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]S3 Storage Integration:
get_store()utility now supports S3 storage using boto3 and theBucketStoreclass, reading all required S3 configuration from environment variables. Use of theMediaStorehas been removed. [1] [2]Code Cleanup:
These changes modernize the storage backend configuration, reduce boilerplate, and make it easier to switch storage backends in the future.