Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the code by moving plotting backend implementations into separate extension modules to reduce unnecessary compilation overhead and technical debt. Key changes include:
- Updating tests to use the mktempdir do-block for better resource management.
- Adding stub functions with clear missing implementation errors in src/dispatch.jl.
- Splitting plotting backend code into dedicated extension modules for Makie, PyPlot, PlutoVista, Plots, MeshCat, VTKView, and updating documentation accordingly.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/runtests.jl | Update tests to use a mktempdir do-block for generating plots. |
| src/dispatch.jl | Introduce stub functions for various plot types with clear error messages. |
| src/common.jl | Add leglocs constant for legend location mapping. |
| src/GridVisualize.jl | Remove direct backend includes/export and adjust module exports. |
| ext/* (all extension modules) | Organize plotting backend code into extensions; update docstrings and inline references. |
| docs/* | Update documentation to reference the new extension modules. |
Comments suppressed due to low confidence (2)
ext/GridVisualizeMeshCatExt.jl:62
- Please add a comment to clarify the purpose of the added parameter '1.0' in this call, so that future maintainers understand its role.
mesh = regionmesh(grid, 1.0, i; cellcoloring = ctx[:cellcoloring])
ext/GridVisualizeMeshCatExt.jl:216
- [nitpick] Consider including a brief comment explaining the role and expected range of 'outlinealpha' to enhance maintainability.
if ctx[:outlinealpha] > 0
pjaap
reviewed
Jun 13, 2025
Member
pjaap
left a comment
pjaap
left a comment
There was a problem hiding this comment.
Thanks for the refactoring. I second the idea to move the code into extensions.
docs/make.jl
Outdated
| mkdocs() | ||
|
|
||
| deploydocs(; repo = "github.com/WIAS-PDELib/GridVisualize.jl.git", devbranch = "main") | ||
| #deploydocs(; repo = "github.com/WIAS-PDELib/GridVisualize.jl.git", devbranch = "main") |
Member
There was a problem hiding this comment.
This shouldn't be disabled, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all plotting backend code to extensions.
Essentially this is meant to remove technical debt.
E.g. if only makie is used, this will spare the compilation of all other code backends.