Skip to content

Fix 1D legend entries in gridplot #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pjaap merged 2 commits into from
Nov 12, 2025
Merged

Fix 1D legend entries in gridplot #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b10740
Update pre-commit config
pjaap Nov 10, 2025
91d63ed
Unify 1D lagend entries to use a space between b/c and ireg
pjaap Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v5.0.0
rev: v6.0.0
hooks:
- id: check-added-large-files
args: [--maxkb=8192]
Expand All @@ -12,11 +12,11 @@ repos:
- id: no-commit-to-branch
args: [--branch, main]
- repo: https://github.com/gitleaks/gitleaks
rev: v8.24.2
rev: v8.29.0
hooks:
- id: gitleaks
- repo: https://github.com/fredrikekre/runic-pre-commit
rev: v1.0.0
rev: v2.0.1
hooks:
- id: runic
- repo: https://github.com/codespell-project/codespell
Expand Down
2 changes: 1 addition & 1 deletion ext/GridVisualizeMakieExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ function gridplot!(ctx, TP::Type{MakieType}, ::Type{Val{1}}, grid)
map(g -> bregionmesh1d(g, gridscale, i), ctx[:grid]);
color = bcmap[i],
linewidth = 4,
label = "b$(i)",
label = "b $(i)",
)
end

Expand Down
4 changes: 2 additions & 2 deletions ext/GridVisualizePlutoVistaExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ function gridplot!(ctx, TP::Type{PlutoVistaType}, ::Type{Val{1}}, grid)

for icell in 1:num_cells(grid)
ireg = cellregions[icell]
label = crflag[ireg] ? "c$(ireg)" : ""
label = crflag[ireg] ? "c $(ireg)" : ""
crflag[ireg] = false

x1 = coord[1, cellnodes[1, icell]]
Expand Down Expand Up @@ -189,7 +189,7 @@ function gridplot!(ctx, TP::Type{PlutoVistaType}, ::Type{Val{1}}, grid)
for ibface in 1:num_bfaces(grid)
ireg = bfaceregions[ibface]
if ireg > 0
label = brflag[ireg] ? "b$(ireg)" : ""
label = brflag[ireg] ? "b $(ireg)" : ""
brflag[ireg] = false
x1 = coord[1, bfacenodes[1, ibface]]
PlutoVista.plot!(
Expand Down
4 changes: 2 additions & 2 deletions ext/GridVisualizePyPlotExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ function gridplot!(ctx, TP::Type{PyPlotType}, ::Type{Val{1}}, grid)

for icell in 1:num_cells(grid)
ireg = cellregions[icell]
label = crflag[ireg] ? "c$(ireg)" : ""
label = crflag[ireg] ? "c $(ireg)" : ""
crflag[ireg] = false

x1 = coord[1, cellnodes[1, icell]] * gridscale
Expand All @@ -188,7 +188,7 @@ function gridplot!(ctx, TP::Type{PyPlotType}, ::Type{Val{1}}, grid)
for ibface in 1:num_bfaces(grid)
ireg = bfaceregions[ibface]
if ireg > 0
label = brflag[ireg] ? "b$(ireg)" : ""
label = brflag[ireg] ? "b $(ireg)" : ""
brflag[ireg] = false
x1 = coord[1, bfacenodes[1, ibface]] * ctx[:gridscale]
ax.plot(
Expand Down
Loading