Merged
Conversation
Fixes #31
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Electron support to the router by handling Windows drive letters in file:// URLs. The key change introduces a sanitized path getter that strips drive letters from Electron file paths, ensuring consistent routing behavior across different environments.
- Adds a new
pathgetter that sanitizes Windows drive letters from file:// URLs - Updates internal routing logic to use the sanitized path instead of raw URL pathname
- Documents Electron usage requirements and setup instructions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/core/RouterEngine.svelte.ts | Adds path getter for Electron drive letter handling and updates routing logic |
| README.md | Documents Electron support and usage instructions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31