feat: Add ignoreForFallback property to Route#43
Merged
Conversation
This also removes the when property. Fixes #20.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new ignoreForFallback property to Route components while removing the when property. The purpose is to allow routes to be ignored when determining whether fallback content should be displayed, providing more granular control over route matching behavior for fallback scenarios.
- Replaces the
whenpredicate function with a simpler booleanignoreForFallbackproperty - Updates route matching logic to consider the
ignoreForFallbackflag when calculatingnoMatches - Adds comprehensive test coverage for the new fallback behavior
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/types.ts | Removes WhenPredicate type and updates CoreRouteInfo to replace when with ignoreForFallback |
| src/lib/core/RouterEngine.svelte.ts | Updates route pattern parsing and matching logic to handle ignoreForFallback property |
| src/lib/core/RouterEngine.svelte.test.ts | Adds test cases for noMatches behavior with ignoreForFallback routes |
| src/lib/Route/Route.svelte | Updates Route component to use ignoreForFallback instead of when property |
| src/lib/Route/README.md | Updates documentation to reflect the new ignoreForFallback property |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This has restored functionality to the Fallback content in the demo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also removes the
whenproperty.Fixes #20.