Skip to content

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Jan 31, 2024

Proposed documentation for the read/unread support in Web3Inbox. This feature has not been implemented yet, but the documentation here should be accurate to what will be built.

Open questions:

  • markAsUnread
  • UpdateNotificationsReadState vs markNotificationAsRead

Remaining work:

  • iOS docs
  • Complete changelog page
  • Feature implementation

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
walletconnect-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 7:02pm
walletconnect-docs-alpha ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 7:02pm

* chore: add api for read unread

* chore: remove all flag

* chore: add docs for vanilla

* chore: change mark as read to promise

* Update docs/api/notify/usage.mdx

Co-authored-by: Chris Smith <[email protected]>

* Update docs/web3inbox/frontend-integration/api.mdx

Co-authored-by: Chris Smith <[email protected]>

* chore: avoid negatives

* chore: add docs for react native

---------

Co-authored-by: Chris Smith <[email protected]>
Copy link
Member Author

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devceline look good?

@chris13524 chris13524 marked this pull request as ready for review April 15, 2024 21:04
@vercel vercel bot temporarily deployed to Preview – walletconnect-docs April 16, 2024 09:30 Inactive
@vercel vercel bot temporarily deployed to Preview – walletconnect-docs-alpha April 16, 2024 09:31 Inactive
Copy link
Contributor

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview – walletconnect-docs-alpha April 16, 2024 18:56 Inactive
@vercel vercel bot temporarily deployed to Preview – walletconnect-docs April 16, 2024 18:56 Inactive
@chris13524
Copy link
Member Author

Wallet support extracted into a separate PR since it has not been implemented yet: #1535

@vercel vercel bot temporarily deployed to Preview – walletconnect-docs-alpha April 16, 2024 19:02 Inactive
@chris13524 chris13524 requested a review from glitch-txs April 16, 2024 19:02
@vercel vercel bot temporarily deployed to Preview – walletconnect-docs April 16, 2024 19:02 Inactive
@chris13524 chris13524 merged commit 642ce7f into main Apr 17, 2024
@chris13524 chris13524 deleted the feat/web3inbox-read-unread branch April 17, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants