Skip to content

Conversation

@enjeck
Copy link

@enjeck enjeck commented Jan 24, 2026

The current theme doesn't provide a table of contents, search or versioning for the docs. Mkdocs provides this for us. This PR migrates to Mkdocs, and hopefuly, the set up is correct for deploying to GitHub pages. In a follow up PR, I'll add support for versioned docs

This is what it looks like:
Screenshot 2026-01-24 at 17 26 36

Comment on lines +13 to +17
- uses: actions/checkout@v4
- name: Configure Git Credentials
run: |
git config user.name github-actions[bot]
git config user.email 41898282+github-actions[bot]@users.noreply.github.com
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably only needed for private repos?

Comment on lines +10 to 13
- **Ensure the bug was not already reported** by searching on GitHub under [Issues](https://github.com/Wasted-Audio/hvcc/issues).

* If you're unable to find an open issue addressing the problem, [open a new one](https://github.com/Wasted-Audio/hvcc/issues/new). Be sure to include a **title and clear description**, as much relevant information as possible, and a minimal **code sample** or an **executable test case** demonstrating the expected behavior that is not occurring.
- If you're unable to find an open issue addressing the problem, [open a new one](https://github.com/Wasted-Audio/hvcc/issues/new). Be sure to include a **title and clear description**, as much relevant information as possible, and a minimal **code sample** or an **executable test case** demonstrating the expected behavior that is not occurring.

Copy link
Author

@enjeck enjeck Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my IDE's formatter automatically changed the formatting of the bullet points. I can revert if you care

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnx, I always forget which one you are "supposed" to use, as the integrated renderer in my IDE looks good.
Settling this in this migration sounds good to me!

@dromer
Copy link
Collaborator

dromer commented Jan 24, 2026

Hey thanks a lot! I've been thinking about how we could add better docs hosting.
Mkdocs also came on my radar recently, but I had not played with it yet.

Adding ToC, dark/light and versioned docs are all super nice and exactly what we need! :)

I'll need to try these builds locally (also something I was never able to reproduce with jekyll) first to be able to get into review.

@dromer
Copy link
Collaborator

dromer commented Jan 24, 2026

First off: do you mind changing the deleted files into renames in the history? :)

@enjeck
Copy link
Author

enjeck commented Jan 24, 2026

I'll need to try these builds locally (also something I was never able to reproduce with jekyll) first to be able to get into review.

After installing dependencies, mkdocs serve should do it

@enjeck
Copy link
Author

enjeck commented Jan 24, 2026

First off: do you mind changing the deleted files into renames in the history? :)

Uh, how do you mean? It there a git command?

@dromer
Copy link
Collaborator

dromer commented Jan 24, 2026

git mv <old_path> <new_path>

This way file history stays intact instead of recreating the files. Somehow it happened only on these two files as far as I can see.

@dromer
Copy link
Collaborator

dromer commented Jan 24, 2026

We should cleanup _config.yml as that was for the jekyll setup.

Also we can add the CONTRIBUTING.md and CODE_OF_CONDUCT.md as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants