Skip to content

fix: stabilize CI by trimming fragile check dependencies - #12

Merged
Wenchao-Ma merged 4 commits into
Wenchao-Ma:masterfrom
sghng:fix/ci-test-cases
Mar 10, 2026
Merged

fix: stabilize CI by trimming fragile check dependencies#12
Wenchao-Ma merged 4 commits into
Wenchao-Ma:masterfrom
sghng:fix/ci-test-cases

Conversation

@sghng

@sghng sghng commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • install only hard dependencies in CI
  • keep the vignette build working by explicitly installing knitr and rmarkdown
  • remove deprecated Rcpp:::LdFlags() usage from the package Makevars files

Why

Recent failures were not caused by GDINA test regressions. CI was failing because:

  • optional suggested packages could fail during installation on old R versions
  • R-devel warns on the deprecated Rcpp:::LdFlags() pattern
  • the package build still needs knitr and rmarkdown because the repo includes a vignette

Validation

  • R CMD INSTALL .
  • _R_CHECK_FORCE_SUGGESTS_=false R CMD check . --no-manual
  • local check reaches Running 'testthat.R' OK

@sghng

sghng commented Mar 7, 2026

Copy link
Copy Markdown
Contributor Author

@Wenchao-Ma Done! The CI checks are now fixed.

@Wenchao-Ma
Wenchao-Ma merged commit 4b81cfa into Wenchao-Ma:master Mar 10, 2026
5 checks passed
@Wenchao-Ma

Copy link
Copy Markdown
Owner

Thank you for fixing this!

@sghng
sghng deleted the fix/ci-test-cases branch March 10, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants